Gitkraken review software#
Gitkraken review code#

It also has a great graph that displays the software developer’s work beautifully. It is designed with a simple and intuitive interface that features light and dark themes. I don’t expect any further contributions in this branch regarding the particular feature it was created for).Overall Opinion: GitKraken is an effective, seamless, and fast GIT client that has enabled developers to be more productive when carrying out their tasks.

I’ve also gone ahead and deleted the origin subtract branch to keep the repo tidy as the branch is now redundant (i.e. The subtract branch has now successfully been merged into main! 🥳 Once the approving review is submitted and given all the checks pass, the pull request is now ready to merge into the main branch! 🎉 Next I’ll submit a final review, this time selecting the Approve option. This indicates that new commits have been made since the discussion was initiated.

We can also see the conversations have an Outdated tag associated with them. Once I was happy each one had been corrected, I responded also and resolved each point individually. Then repeat the process we’ve just been through. If all checks aren’t passing, have a look at the logs of the checks and/or re-inspect the changes to the files to spot any problems. If you still spot problems when you’re reviewing the changes, repeat the process we’ve just been through. Now my team can go back to GitKraken Client and make the corrections to any errors I’ve flagged Correct errors and respond to request for changes The fact that I’ve requested changes is also flagged. This posts my comments into the PR discussion tab where the author of the PR can respond to them. In the top-right corner and select the Changes requested option. GitHub has automatically flagged a couple more issues (2 files that don’t end in a newline, indicated by the ) so I’ve also asked my team mate to correct those.

Gitkraken review code#

In the case of the subtract PR, I identified the line of code containing the error (line #1 in pythoncalculator/subtract.py) and added a comment identifying the error for my team mate to correct.

To add your comment and initiate a review. Once you’ve added your first comment, click on This opens a box to add your review comment. It also allows us to post review comments to an individual line of code, by clicking on the at the left hand side margin of the line of code. This tab shows all added and deleted lines of code in each file commited in the PR. Start the review by first inspecting the changes to the files made in the pull request by clicking on the Files changed tab of the PR. To check that everything has been completed correctly, refer to the Appendix in this chapter, which has the correct files and file content that should have been committed for each issue. No problem though! The review stage will help us inspect and guide our team mates to correct any additional errors. You may also have additional errors if the instructions in the issue were followed incorrectly by your team mates. The failing tests, and in particular, the linting check by flake8 points to a missing colon in the subtract function definition. Problems are also indicated by the failing tests which we can inspect. Review 1st Subtract Pull RequestĪs I mentioned, there is atleast one error in the Pull Request as a result of erroneous instructions in the issue. In this case, it was made by team mate bobturneruk, tackling issue #2 Add subtraction function via pull request #5. Let’s use the first pull request made to the repo as an example. The PR review stage provides opportunity for any problems to be identified and dealt with before merging. We’ve actually snuck some errors into the instructions we provided in your team mates issues. Review 2nd Pull Request: handling merge conflictsĪs the owner, it’s time to review the Pull Requests the rest of your team mates have opened. Review 1st Pull Request: asking for corrections Cloning and Collaborating with GitKraken Client